-
Notifications
You must be signed in to change notification settings - Fork 330
DOCS: Accessibility update to comply with our accessibility legal requirements. #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2185 +/- ##
===========================================
- Coverage 65.45% 65.44% -0.01%
===========================================
Files 367 367
Lines 53505 53505
===========================================
- Hits 35024 35019 -5
- Misses 18481 18486 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
||
| Once you have created and assigned project-wide actions, the Input System Package page in Project Settings displays the **Actions Editor** interface. Read more about how to use the [Actions Editor](ActionsEditor.md) to configure your actions. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand on why this has to be removed? It provides the reader with the expectation of what is described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For UI images, documentation is moving away from providing screenshots of the UI if the information is provided in-text to lower upkeep needed to keep images updated with UI changes. In this case, the text itself leads to the UI reference page for the ActionsEditor, so users who want to know more would be going to that page and see a fully labelled version of the same image in greater detail, so it makes this screenshot slightly redundant.
|
|
||
| You can also delete all action maps, or reset all the actions back to the default values from the **more** (⋮) menu at the top right of the Input Actions section of the settings window, below the Project Settings window search field. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, for the majority of the screenshot doesn't provide relevant information that we want users to focus on, as the main thing is the highlighted location of the 'more' menu in red. But the location and icon is already described in the text.
In this case, alt-text provided in the image caption would become a repeat of what has already been said above by the adjacent/accompanying text, so the image is decorative.
However if you feel the image is still important, it can be restored and we'll leave the alt-text blank.
jfreire-unity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thank you!
ekcoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just wondering if we shouldn't highlight the change in the CHANGELOG.md? Its non-functional, but still a relevant update/fix.
Pauliusd01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text seems fine to me but I still see some CI failures, reran them
|
Still see valid sounding failures for example: playmode Test Failure: APIVerificationTests.API_DocumentationManualDoesNotHaveMissingOrUnusedImages |
- Restored removed images (see #2185) - Added the image references back to the table on the Workflows landing page - Also replaced makeshift Notes and Tips with DocFx admonitions
Description
These are necessary changes made to images and their alt-text to comply with our accessibility legal requirements.
Testing status & QA
NA
Overall Product Risks
These are purely image and table changes made to docs and zero risk.
Comments to reviewers
Removal of redundant images is also part of the accessibility policy, which is why some were removed as text already contained the info.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: